Patches end of page #3459

alexislefebvre · 2014-01-10T19:03:25Z

Q	A
Doc fix?	yes
New docs?	no
Applies to	2.3+
Fixed tickets	#3458

…cation provider

…ny documentation

…time option (bicpi) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Form Types] Document "with_minutes" time/datetime option | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3410 (task `time > with_minutes`) The `datetime` field also has a `with_minutes` option. Using the `single_text` widget type might not work as expected using `with_minutes=false` if the browser supports HTML5's `time` input type. Most browsers seem to only support `hh:mm` or `hh:mm:ss` formats for the value attribute (resetting the value to `--:--` if using an hour value only). This might not be the case for every browser because I couldn't find anything in the HTML5 spec that says a partial time cannot be an hour only. I've added a `caution` box for this. Commits ------- 1e88b9d Fix "versionadded" position 8cfb850 [Reference][Form Types] Document "with_minutes" time/datetime option

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | #3442

I just mentioned the fact that `push -f` is usually required when rebasing and explicit that the "2.2 when bugfixing" is a follow up on the previous example (Not necessarily explicit at first).

As per WouterJ request: #3421 (comment)

@xabbuh

As per @xabbuh suggestion: #3421 (comment)

@cordoval

As per @cordoval suggestion: #3421 (comment)

…warning for when forbidding anonymous users (cordoval) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Custom Authentication Provider] add a note of warning for when forbidding anonymous users | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | #3212 | | License | CC-ASA 3.0 Unported | Sent using [Gush](https://github.com/cordoval/gush) Commits ------- 244d756 add note when forbidding access to anonymous users on custom authentication provider

@wouterj

…e handler proxies (cordoval) This PR was merged into the 2.3 branch. Discussion ---------- [Session Configuration] add clarifying notes on session save handler proxies | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | #2889 | | License | CC-ASA 3.0 Unported | Sent using [Gush](https://github.com/cordoval/gush) Commits ------- 771b862 address comments from @wouterj 2888d00 answer some questions and clarify the best chapter imo from the symfony documentation

…e (nykopol) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Form Types] Add "max_length" option in form type | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3410 (task Form -> max_length) Commits ------- b53a227 fix last typo on max length option d6800d3 fix typo in previous commit 391fe30 fix typo in previous commit 2156545 add max_length to form field type

This PR was merged into the 2.3 branch. Discussion ---------- add missing code-block directive | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- 9b1aab8 add missing code-block directive

…bbuh) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #3415). Discussion ---------- [#3334] the data_class option was not introduced in 2.4 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- c96e6eb [#3334] the data_class option was not introduced in 2.4

This PR was merged into the 2.3 branch. Discussion ---------- add empty_data option where required option is used | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- d9c6a85 add empty_data option where required option is used

@wouterj

…anielcsgomes) This PR was merged into the 2.3 branch. Discussion ---------- Removed code references to Symfony Standard Distribution | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | After talk with @wouterj on #3426 and IRC about references in the standalone Console component to the framework I decided to submit this PR to change the code that have some references to the Symfony Standard Distribution in the code. Commits ------- 4fd7022 Removed code references to Symfony Standard Distribution

This PR was merged into the 2.3 branch. Discussion ---------- Fix issue #3442 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | #3442 Commits ------- 559a227 Fix issue #3442

@wouterj

This PR was merged into the 2.3 branch. Discussion ---------- Overridden tweak Hi guys! Tiny change (so skipping the PR table) - see #3407 (comment) Thanks! Commits ------- 8f3e6c7 [#3407] Adding a missing section via tip from @wouterj

alexislefebvre · 2014-01-10T19:23:06Z

I don't understand why so many commits are attached here, I must have made a mistake but I don't know github enough to fix it.

stof · 2014-01-10T19:29:24Z

it is because you created your branch based on 2.3 and you selected master as target (which does not have yet all the latest changes merged in 2.3)

alexislefebvre · 2014-01-10T19:36:18Z

Ok, I saw it in the documentation after having sent my PR. :-(

alexislefebvre · 2014-01-10T19:36:45Z

Please tell me if there's a way to revert my mistake.

xabbuh · 2014-01-10T20:29:17Z

You can't change in GitHub the branch on which this should be applied. But @weaverryan can merge this into 2.3 anyway.

xabbuh · 2014-01-10T20:39:07Z

Anyways, this a good catch but unfortunately #3458 is already adressed in #3455.

alexislefebvre · 2014-01-10T21:10:34Z

Ok, thanks, I should have looked closely to the other PRs. I will update the issue which describe another problem. This PR can be deleted, if it's possible.

xabbuh and others added 30 commits January 3, 2014 12:50

add empty_data option where required option is used

d9c6a85

add missing code-block directive

9b1aab8

add note when forbidding access to anonymous users on custom authenti…

244d756

…cation provider

answer some questions and clarify the best chapter imo from the symfo…

2888d00

…ny documentation

address comments from @wouterj

771b862

[Reference][Form Types] Document "with_minutes" time/datetime option

8cfb850

Fix "versionadded" position

1e88b9d

add max_length to form field type

2156545

fix typo in previous commit

391fe30

fix typo in previous commit

d6800d3

fix last typo on max length option

b53a227

Fix issue #3442

559a227

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | #3442

[#3407] Adding a missing section via tip from @wouterj

8f3e6c7

[Contributing] Clarify the rebase operation

e1d344f

I just mentioned the fact that `push -f` is usually required when rebasing and explicit that the "2.2 when bugfixing" is a follow up on the previous example (Not necessarily explicit at first).

[Contributing] Fix single vs double backtick issues

4544ea1

[Contributing] Add PSR-1 and 2 links

d5009c1

[Contributing] Replace mentions of 2.2 for 2.3

1a670d1

As per WouterJ request: #3421 (comment)

[Contributing] Fix "When you finish" => "When you are finished"

806a86f

As per @xabbuh suggestion: #3421 (comment)

[Contributing] Replace HEAD~3 by upstream/master

13222c9

As per @cordoval suggestion: #3421 (comment)

the data_class option was not introduced in 2.4

69a2ed1

Removed code references to Symfony Standard Distribution

4fd7022

bug #3444 Fix issue #3442 (ifdattic)

d9d7c58

This PR was merged into the 2.3 branch. Discussion ---------- Fix issue #3442 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | #3442 Commits ------- 559a227 Fix issue #3442

weaverryan and others added 2 commits January 10, 2014 08:02

bug #3448 Overridden tweak (weaverryan)

42c80d1

This PR was merged into the 2.3 branch. Discussion ---------- Overridden tweak Hi guys! Tiny change (so skipping the PR table) - see #3407 (comment) Thanks! Commits ------- 8f3e6c7 [#3407] Adding a missing section via tip from @wouterj

Removed spaces at the beginning of the final paragraph

d5ab588

alexislefebvre closed this Jan 10, 2014

alexislefebvre deleted the patches_end_of_page branch January 10, 2014 21:10

alexislefebvre mentioned this pull request Jan 10, 2014

Comments about command lines ("Submitting a Patch" page) #3458

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Patches end of page #3459

Patches end of page #3459

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

stof commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

xabbuh commented Jan 10, 2014

Uh oh!

xabbuh commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

Uh oh!

Uh oh!

Patches end of page #3459

Patches end of page #3459

Uh oh!

Conversation

alexislefebvre commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

stof commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

xabbuh commented Jan 10, 2014

Uh oh!

xabbuh commented Jan 10, 2014

Uh oh!

alexislefebvre commented Jan 10, 2014

Uh oh!

Uh oh!