Skip to content

[Config] add cautionary note on ini file loader limitation #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2014
Merged

[Config] add cautionary note on ini file loader limitation #3431

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4436dae
add warning for inifile loader
cordoval Jan 6, 2014
dd3dd70
address comments, even the Boolean one
cordoval Jan 10, 2014
4f02a8a
address comments
cordoval Jan 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions components/config/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ The Config component provides several classes to help you find, load, combine,
autofill and validate configuration values of any kind, whatever their source
may be (YAML, XML, INI files, or for instance a database).

.. caution::

``IniFileLoader`` parses with the `parse_ini_file` function, therefore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IniFileLoader [...]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

:phpfunction:`parse_ini_file`

it can only configure parameters as string values. For other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about:

therefore, you can only set parameters to string values. To set parameters
to other data types (e.g. ...)

data types support (e.g. Boolean, integer, etc), the other loaders
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use boolean here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i am bracing for a long debate here 💃 but i will comply. Youth! they try to change everything these days 👶

are recommended.

Installation
------------

Expand Down