Skip to content

[Book][Validation] Fix small typos #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Book][Validation] Fix small typos #3371

wants to merge 1 commit into from

Conversation

iamdto
Copy link
Contributor

@iamdto iamdto commented Dec 19, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.2+
Fixed tickets -

This fixes syntax highlighting and remove a trailing whitespace on the validation book.

@xabbuh
Copy link
Member

xabbuh commented Dec 19, 2013

Good catch. But unfortunately there's already a PR (see #3345).

@wouterj wouterj closed this Dec 19, 2013
@iamdto
Copy link
Contributor Author

iamdto commented Dec 20, 2013

Yeah you're right, I didn't see this one.

@xabbuh @wouterj @weaverryan: maybe PRs and issues titles should be prefixed by something like the first two levels of the hierarchy (i.e. [Cookbook][Assetic], [Book][Assetic] etc.) in order to avoid duplicate PRs?

For example the documentation for contributing to the core code state that:

To ease the core team work, always include the modified components in your
pull request message, like in:

    [Yaml] fixed something
    [Form] [Validator] [FrameworkBundle] added something

But there is no such thing for the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants