Added "data" option to the "Inherited options" table. #3333
Conversation
mtrojanowski
commented
Dec 14, 2013
mtrojanowski
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | #2871 |
|
👍 |
| @@ -21,7 +21,8 @@ forms, which is useful when creating forms that expose one-to-many relationships | |||
| | | - `prototype_name`_ | | |||
| +-------------+-----------------------------------------------------------------------------+ | |||
| | Inherited | - `label`_ | | |||
| | options | - `error_bubbling`_ | | |||
| | options | - `data`_ | | |||
| | | - `error_bubbling`_ | | |||
There was a problem hiding this comment.
Imho it is rather confusing that the order of the options in the table differs from the order below. What do you guys think? This is, of course, not exclusively related to this PR.
There was a problem hiding this comment.
The entries are anchors anyway so I don't think it's that of a problem.
There was a problem hiding this comment.
I prefer to put them in the order of the file (we did that everywhere currently)
|
Updated the changes based on previous comments and discussion in #2871:
|
|
|
||
| The default values for Form fields are taken directly from the |
There was a problem hiding this comment.
Fixed in the next commit. Once we agree that everything is fine I can squash the commits.
|
👍 (which means: I approve this PR 😉) |
Fixed sorting of options. Made the note on selecting the checkbox by default more clear. Added note on defaults to the `data` option partial.
|
Rebased to latest 2.3. and squashed. |
|
👍 |
Added "data" option to the "Inherited options" table.
|
Wow, this is really great! Lot's of very precise changes, correct branch, squashes - you're welcome back here any time Michał ;). And don't be a stranger, Leanna and I very much liked hanging out with you! Cheers and Thanks! |
|
I did promise you two more PR's in the coming year so I will become a much more frequent guest here. I had a really nice time with you guys too (and it's really cool to see my name written with the Polish letters! :) ) Will contribute soon :) |
|
👍 nice |
