Skip to content

Moved "Impersonating a User" to a cookbook entry #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 26, 2013

Conversation

romaricdrigon
Copy link
Contributor

Hi,

I've been looking to ways of shortening Security book entry, which is pretty impressive.
Impersonating a User seems to be a less common case, and in no way understanding it is necessary to understand the Security component.
Then I moved it to its own cookbook entry, added a link to it at the bottom of the Security book, updated indexes.

Its content was not modified, nothing new, nothing fixed. But I hope it'll make contributing to it easier :)

@romaricdrigon
Copy link
Contributor Author

I know you love tables, so here's one

Q A
Doc fix? no - except regarding lisibility
New docs? no, nothing modified
Applies to 2.3+
Fixed tickets none

@wouterj
Copy link
Member

wouterj commented Dec 14, 2013

👍 lovely change! Making the book articles shorter has been on my list for ages :)

.. index::
single: Security; Impersonating User

How to impersonate a User
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uppercase impersonate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

@romaricdrigon
Copy link
Contributor Author

@xabbuh thanks for your feedback, those are fixed now

weaverryan added a commit that referenced this pull request Dec 26, 2013
Moved "Impersonating a User" to a cookbook entry
@weaverryan weaverryan merged commit 6e2f14e into symfony:2.3 Dec 26, 2013
@weaverryan
Copy link
Member

Really awesome - thanks Romaric!

@romaricdrigon romaricdrigon deleted the feat-impersonating-user branch December 26, 2013 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants