Skip to content

Documented CSRF protection in login forms #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 26, 2013
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion book/security.rst
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ First, enable form login under your firewall:
<config>
<firewall name="secured_area" pattern="^/">
<anonymous />
<form-login login_path="login" check_path="login_check" />
<form-login login-path="login" check-path="login_check" />
</firewall>
</config>
</srv:container>
Expand Down Expand Up @@ -519,6 +519,11 @@ Finally, create the corresponding template:
<button type="submit">login</button>
</form>

.. caution::

This login form is currently not protected against CSRF attacks. Read
:doc:`/cookbook/security/csrf_in_login_form` on how to protect your login form.

.. tip::

The ``error`` variable passed into the template is an instance of
Expand Down
5 changes: 3 additions & 2 deletions book/validation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,9 @@ Next, to actually validate an ``Author`` object, use the ``validate`` method
on the ``validator`` service (class :class:`Symfony\\Component\\Validator\\Validator`).
The job of the ``validator`` is easy: to read the constraints (i.e. rules)
of a class and verify whether or not the data on the object satisfies those
constraints. If validation fails, an array of errors is returned. Take this
simple example from inside a controller::
constraints. If validation fails, a non-empty list of errors
(class :class:`Symfony\\Component\\Validator\\ConstraintViolationList`) is
returned. Take this simple example from inside a controller:

// ...
use Symfony\Component\HttpFoundation\Response;
Expand Down
115 changes: 115 additions & 0 deletions cookbook/security/csrf_in_login_form.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
.. index::
single: Security; CSRF in the Login Form

Using CSRF in the Login Form
============================

When using a login form, you should make sure that you are protected for CSRF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protected against

(`Cross-site request forgery`_). The Security component already has build-in support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built-in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-Site Request Forgery to better match the abbreviation?

form CSRF. In this article, you'll learn how you can use it in your login form.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for instead of form

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comma after article i think


Configuring CSRF
----------------

At first, you have to configure the security component so it can use CSRF protection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security?

The security component needs a CSRF provider. You can set this to use the default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

provider provided by the Form component:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default provider available in the Form component


.. configuration-block::

.. code-block:: yaml

# app/config/security.yml
security:
firewalls:
secured_area:
# ...
form_login:
# ...
csrf_provider: form.csrf_provider

.. code-block:: xml

<!-- app/config/config.xml -->
<?xml version="1.0" encoding="UTF-8" ?>
<srv:container xmlns="http://symfony.com/schema/dic/security"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:srv="http://symfony.com/schema/dic/services"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">

<config>
<firewall name="secured_area">
<!-- ... -->

<form-login csrf-provider="form.csrf_provider" />
</firewall>
</config>
</srv:container>

.. code-block:: php

// app/config/security.php
$container->loadFromExtension('security', array(
'firewalls' => array(
'secured_area' => array(
// ...
'form_login' => array(
// ...
'csrf_provider' => 'form.csrf_provider',
)
)
)
));

The Security component can be configured further, but this is all information it needs
to be able to use CSRF in the login form.

Rendering the CSRF field
------------------------

Now the Security component checks for CSRF tokens, you have to add a *hidden* field
to the login form containing the CSRF token. By default, this field is named as
``_csrf_token``. That hidden field has to contain the CSRF token, which can be generated
by using the ``csrf_token`` function. That function requires a token ID, which is
must be set to ``authenticate`` when using the login form:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which must be set, so no is


.. configuration-block::

.. code-block:: html+twig

{# src/Acme/SecurityBundle/Resources/views/Security/login.html.twig #}

{# ... #}
<form action="{{ path('login_check') }}" method="post">
{# ... the login fields #}

<input type="hidden" name="_csrf_token"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is not done automatically when i do {{ form(form) }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no form variable available when using login forms afaik

value="{{ csrf_token('authenticate') }}"
>

<button type="submit">login</button>
</form>

.. code-block:: html+php

<!-- src/Acme/SecurityBundle/Resources/views/Security/login.html.php -->

<!-- ... -->
<form action="<?php echo $view['router']->generate('login_check') ?>" method="post">
<!-- ... the login fields -->

<input type="hidden" name="_csrf_token"
value="<?php echo $view['form']->csrfToken('authenticate') ?>"
>

<button type="submit">login</button>
</form>

After this, you have protected your login form for CSRF attacks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

against


.. tip::

You can change the name of the field by setting ``csrf_parameter`` and the token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] and change the token [...]

ID by setting ``intention`` in your configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good if this is made explicit with a code example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


.. _`Cross-site request forgery`: http://en.wikipedia.org/wiki/Cross-site_request_forgery