[Components][Console] Fix askConfirmation() description #3265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| In this case, the user will be asked "Continue with this action?", and will | ||
| return ``true`` if the user answers with ``y`` or ``false`` if the user answers | ||
| with ``n``. The third argument to | ||
| :method:`Symfony\\Component\\Console\\Helper\\DialogHelper::askConfirmation` |
There was a problem hiding this comment.
no need to use the api link twice imo
There was a problem hiding this comment.
Where is the first usage?
|
It also works for 'yes' and 'no' afaik |
|
Seems that everything starting with |
weaverryan
added a commit
that referenced
this pull request
Dec 18, 2013
[Components][Console] Fix askConfirmation() description
|
I like it, and agree that it's probably not really important that someone knows that yes/no and other combinations work. They want the user to be asked something, this explains that nicely. Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
askConfirmation()only terminates on enteringy,nor nothing. API link added.