Changed parameter container to request #3216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to pass @service_container to the voter, @request is enough.
| use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface; | ||
| use Symfony\Component\Security\Core\Authentication\Token\TokenInterface; | ||
|
|
||
| class ClientIpVoter implements VoterInterface | ||
| { | ||
| public function __construct(ContainerInterface $container, array $blacklistedIp = array()) | ||
| public function __construct(Request $request, array $blacklistedIp = array()) |
There was a problem hiding this comment.
should be the request or the request_stack? 👶
There was a problem hiding this comment.
yes, indeed. For 2.3 this should be changed to use the request_stack
There was a problem hiding this comment.
I thought it is for 2.4+ as mentioned in here.
I'll update PR
There was a problem hiding this comment.
oh yeah, my mistake. Could you please reopen this PR for the 2.4 branch (master)?
There was a problem hiding this comment.
Ok, I will do the same changes for 2.4 (master). But what about this PR (current branch) ?
There was a problem hiding this comment.
This pr should be closed, for the same reasons as mentioned in #3211
maks-rafalko
added a commit
to maks-rafalko/symfony-docs
that referenced
this pull request
Nov 22, 2013
There is no need to pass @service_container to the voter, @request is enough. please see symfony#3216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to pass @service_container to the voter, @request is enough.