Skip to content

Fixed namespace separator #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2013
Merged

Fixed namespace separator #3199

merged 1 commit into from
Nov 28, 2013

Conversation

szjani
Copy link

@szjani szjani commented Nov 17, 2013

The visible class name is misleading.

@wouterj
Copy link
Member

wouterj commented Nov 17, 2013

good catch!

But as it is a class name, it should be placed in a literal. Could you please revert this change and change the double quotes to 2 backticks instead?

@xabbuh
Copy link
Member

xabbuh commented Nov 17, 2013

Shouldn't this also be put in a class directive?

@wouterj
Copy link
Member

wouterj commented Nov 17, 2013

no, the api for the proxymanager library is not rendered on the api.symfony.com site

weaverryan added a commit that referenced this pull request Nov 28, 2013
Fixed namespace separator
@weaverryan weaverryan merged commit 19493af into symfony:2.3 Nov 28, 2013
@weaverryan
Copy link
Member

Thanks for fixing this Szurovecz! I've also made the tweak suggested by @wouterj.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants