Skip to content

add clarification for order in which event listeners will be executed #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shieldo
Copy link
Contributor

@shieldo shieldo commented Nov 13, 2013

Clearing up ambiguity (are event listeners executed in priority or number order?).

Clearing up ambiguity (are event listeners executed in priority or number order?).
@@ -91,7 +91,7 @@ using a special "tag":

There is an additional tag option ``priority`` that is optional and defaults
to 0. This value can be from -255 to 255, and the listeners will be executed
in the order of their priority. This is useful when you need to guarantee
in the order of their priority (highest to lowest). This is useful when you need to guarantee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add line breaks

@wouterj
Copy link
Member

wouterj commented Nov 14, 2013

Could you please include the PR template?

@wouterj
Copy link
Member

wouterj commented Nov 14, 2013

And 2.0 is not longer maintained, it should be merged in 2.2

weaverryan added a commit that referenced this pull request Nov 16, 2013
@weaverryan
Copy link
Member

Thanks Douglas! I patched this into the 2.2 branch at sha: 262e787 with the line break changes thanks to @wouterj at sha: 7b3b017

Cheers!

@weaverryan weaverryan closed this Nov 16, 2013
@shieldo
Copy link
Contributor Author

shieldo commented Nov 16, 2013

Thanks so much for clearing this up, Ryan!

@shieldo shieldo deleted the patch-9 branch November 16, 2013 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants