Skip to content

[Components][Console] Replace ambiguous heading to generate unique anchor #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2013
Merged

[Components][Console] Replace ambiguous heading to generate unique anchor #3131

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77d71b5
[Components][Console] Replace ambiguous heading to generate unique an…
bicpi Oct 30, 2013
3785c68
[Components][Console] Fix lowercase to uppercase
bicpi Nov 5, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/console/helpers/dialoghelper.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ in the last argument. Using ``false`` means the amount of attempts is infinite.
The user will be asked as long as he provides an invalid answer and will only
be able to proceed if her input is valid.

Hiding the User's Response
~~~~~~~~~~~~~~~~~~~~~~~~~~
Validating a hidden Response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validating a Hidden Response

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought about this one, but when looking at e.g.

  • Asking the User for confirmation
  • Asking the User for Information
  • Testing a Command which expects input

I wasn't sure what to capitalize ;-)

If we rename I can update this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Asking the User for Confirmation
  • Testing a Command which Expects Input

is what I'd say

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should write this standard 👶

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard, iirc (which Fabien explained to me long long ago) is to capitalize nouns and adjectives, but not verbs. So, Validating a Hidden Response would be correct. Two examples:

I've opened up a PR #3149 to clarify these.

So after that, are we happy with the header names here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh expects lower case

Testing a Command which expects Input

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan copied chief 👶

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're happy I would update to uppercase "Hidden" 😃

~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.. versionadded:: 2.2
The ``askHiddenResponseAndValidate`` method was added in Symfony 2.2.
Expand Down