Skip to content

Fix typo in Redirect Controller article #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 25, 2013

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Aug 25, 2013

What do you think about merging this also into 2.0 and 2.1? I'd appreciate if we fixed this error in these old versions, too.

weaverryan added a commit that referenced this pull request Sep 9, 2013
Fix typo in Redirect Controller article
@weaverryan weaverryan merged commit fec1115 into symfony:2.2 Sep 9, 2013
@weaverryan
Copy link
Member

Thanks Wouter!

@xabbuh It's a nice idea in theory, but I tried to patch this into the 2.0 branch and already conflicts. We can try this sometimes, but if it doesn't merge cleanly, I don't think it's worth it.

Cheers!

@xabbuh
Copy link
Member

xabbuh commented Sep 9, 2013

I didn't meant to cause you any trouble, @weaverryan. It would have been nice if it was easy to merge. But I agree that it's not worth otherwise.

@wouterj wouterj deleted the fix_typo_redirectcontroller branch September 9, 2013 14:46
@weaverryan
Copy link
Member

No worries :) - I expected it to be an easy merge, which is why I tried it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants