-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Updating Doctrine field types #2920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
* **Other Types** | ||
|
||
* ``boolean`` | ||
* ``object`` (serialized and stored in a ``CLOB`` field) | ||
* ``array`` (serialized and stored in a ``CLOB`` field) | ||
* ``simple_array`` (serialized using implode() and explode(), with a comma as delimiter, and stored in a ``CLOB`` field) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serialized using :phpfunction:`implode` and :phpfunction:`explode`, with a ....
Updated! 👍 |
|
||
* **Other Types** | ||
|
||
* ``boolean`` | ||
* ``object`` (serialized and stored in a ``CLOB`` field) | ||
* ``array`` (serialized and stored in a ``CLOB`` field) | ||
* ``simple_array`` (serialized using :phpfunction:`implode()` and :phpfunction:`explode()`, with a comma as delimiter, and stored in a ``CLOB`` field) | ||
* ``json_array`` (serialized using :phpfunction:`json_encode()` and :phpfunction:`json_decode()`, and stored in a ``CLOB`` field) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please wrap the two lines above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent with our documentation standards (see the second item in the list). Additionally, it make the raw format easier to read.
Hi Klaus! Do you happen to know what version these were added to Doctrine? I want to make sure these are merged into the correct Symfony branch. If you happen to know what version of Doctrine these are from, then we can see which version of Symfony that goes with (by default). Thanks! |
@@ -1418,12 +1418,19 @@ using. The following types are supported in Doctrine: | |||
* ``date`` | |||
* ``time`` | |||
* ``datetime`` | |||
* ``datetimetz`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of doctrine 1.0
Hi Klaus! I've just patched this into the 2.2 branch at sha: 3e6b891, sha: 18c0e37 and sha: 955abe4, removed the types not available until 2.3 at sha: abd4b2d and finally re-added them to the 2.3 branch at sha: e2e8372. Big thanks also to Wouter for doing the work of looking up what versions things came from. Thanks! |
No description provided.