[DIC] Added note on untrimmed parameters (XML) #2876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,6 +97,21 @@ rather than being tied up and hidden with the service definition: | |||
| ->register('mailer', 'Mailer') | |||
| ->addArgument('%mailer.transport%'); | |||
|
|
|||
| .. note:: | |||
|
Whoa, that's quick! 🚀 👍 |
|
This should be placed somewhere below, where we talk about constants as parameters |
|
@wouterj It is true for all parameters, not only for constants (it can hurt you for class names too for instance) |
|
Well, make it indeed easier to understand. What about taking the mailer example? Setting And after that, can you please squash your commits (if you know how to do that)? |
|
Done, I added the exact value of the retrieved parameter, so we can see the line returns and spaces, and I also added a note on constants and class names which can throw exceptions. |
| trimmed. | ||
|
|
||
| This means that the following configuration sample will have the value | ||
| `\n sendmail\n`: |
In XML configuration, the value between` parameter` tags isn't trimmed, which can lead to unexpected behavior. See symfony/symfony#8661
|
👍 great note Loïc (and a clean PR)! I've patched this into the 2.2 branch at sha: 1b707dd Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In XML configuration, the value between
parametertags isn't trimmed,which can lead to unexpected behavior.
See symfony/symfony#8661