-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added documentation about profiler matchers #2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wouterj
commented
Jun 30, 2013
Q | A |
---|---|
Doc fix? | no |
New docs? | yes |
Applies to | all |
Fixed tickets | #2104 |
========================================== | ||
|
||
The profiler is by default only activated in the development environment. But | ||
it's imaginable that a developer want to always see the profiler, even in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wants
we should keep track of symfony/symfony#8352 and change it on the master branch |
Hey Wouter! So, this is a really nice entry. BUT, the original issue was not a good one. This feature is actually already documented, here: http://symfony.com/doc/current/book/internals.html#configuration Now, I think it's better to have this as a standalone cookbook entry, but since the documentation exists, we need to tweak few things with this PR:
@wouterj - can you make these changes? Thanks! |
Using the build-in Matcher | ||
-------------------------- | ||
|
||
Symfony2 provides a :class:`build-in matcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong wrapping
"the original issue was not a good one" And do you really think it's needed to add a path example? I'll add some information in the paragraph about the path option and fix (1) this afternoon. |
Merged! Minor tweaks at sha: 826197b. This reads very well and I like the example you chose. Thanks Wouter! |