Skip to content

Added documentation about profiler matchers #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2013
Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jun 30, 2013

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets #2104

==========================================

The profiler is by default only activated in the development environment. But
it's imaginable that a developer want to always see the profiler, even in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wants

@wouterj
Copy link
Member Author

wouterj commented Jul 8, 2013

we should keep track of symfony/symfony#8352 and change it on the master branch

@weaverryan
Copy link
Member

Hey Wouter!

So, this is a really nice entry. BUT, the original issue was not a good one. This feature is actually already documented, here: http://symfony.com/doc/current/book/internals.html#configuration

Now, I think it's better to have this as a standalone cookbook entry, but since the documentation exists, we need to tweak few things with this PR:

  1. Remove the stuff in the internals doc and replace with a link to this new cookbook entry
  2. Make sure that a few of the things that are documented in the internals version (e.g. matching by path - that may actually be the only missing thing) is documented in the new version.

@wouterj - can you make these changes?

Thanks!

Using the build-in Matcher
--------------------------

Symfony2 provides a :class:`build-in matcher
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong wrapping

@wouterj
Copy link
Member Author

wouterj commented Jul 29, 2013

"the original issue was not a good one"
Do you mean it was talking about something else or that it was already fixed?

And do you really think it's needed to add a path example? I'll add some information in the paragraph about the path option and fix (1) this afternoon.

@weaverryan weaverryan merged commit 1038fb8 into symfony:2.2 Aug 10, 2013
@weaverryan
Copy link
Member

Merged! Minor tweaks at sha: 826197b. This reads very well and I like the example you chose.

Thanks Wouter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants