[WIP] Rewrote Templating Docs #2735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| ============= | ||
|
|
||
| The assets helper's main purpose is to make your application more portable by | ||
| generating assets's paths: |
|
Yes, we can do that. I somewhat wrote everything myself, so a grammar check is definitely needed... I already see some errors, I'll fix thoses tomorrow if you don't merge it tonight. And I like to get answers on your 2 mentions here 😺 |
|
|
||
| * :doc:`/components/templating` | ||
| * :doc:`/components/templating/introduction` | ||
| * :doc:`/components/templating/usage` |
There was a problem hiding this comment.
This document is already removed.
|
@weaverryan I've updated it and squashed the commits. Ready for review! @bghazy I'm sorry, your contribution is lost while squashing. We still have your content, but it's now on my name :( |
|
@wouterj no problem ... we are all working for the community :) |
weaverryan
added a commit
that referenced
this pull request
Aug 10, 2013
[WIP] Rewrote Templating Docs
|
Hi Wouter! Merged! Yea! Very nice job with this! I've made my normal small tweaks at sha: e24376c, but it was all very minor. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to fix #955 and it turns out that a complete rewrite was better. It uses the same structure as the console documentation: helper docs got their own articles and one big article talking about the other functionality.
TODO
From the things ryan gave in #955:
EngineInterface@weaverryan, what do you mean with (1)? A doc about how to create your own engine?
The Future
The
cookbook/templating/PHPdoc is now somewhat equal to this one. In the future, we should do something like what #2545 does withbook/translation.