Varnish purge fix #2654
Merged
Varnish purge fix #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThijsFeryn
commented
May 22, 2013
ThijsFeryn
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all (or 2.1+) |
| Fixed tickets | #2653 |
|
Thanks Thijs! Is it possible to add comments in VCL files? Maybe it would be interesting to comment the VCL code for most important sections. |
|
OK, Hugo, I added a bit a comment. Is it good enough like that? |
|
Looks pretty good thanks. The best would be to squash the commits together. Ping me at the conference if you need help to do it. |
|
Squashed the commits. Ready to merge it? |
|
Wow, this is much more detailed - great idea and execution with the comments. Thanks Thijs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.