Skip to content

[WCM] Documented that "empty_value" can be used for expanded choice fields #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WCM] Documented that "empty_value" can be used for expanded choice fields #2605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions reference/forms/types/options/empty_value.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@ empty_value

**type**: ``string`` or ``Boolean``

.. versionadded:: 2.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must remove this empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we keep an empty line after other control clauses then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the versionadded directive is a strange directive which can't handle a new line after it. All other directive can.

Since Symfony 2.3, empty values are also supported if the ``expanded``
option is set to true.

This option determines whether or not a special "empty" option (e.g. "Choose an option")
will appear at the top of a select widget. This option only applies if both
the ``expanded`` and ``multiple`` options are set to false.
will appear at the top of a select widget. This option only applies if the
the ``multiple`` option is set to false.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One "the" too much.


* Add an empty value with "Choose an option" as the text::

Expand All @@ -26,4 +31,4 @@ is false::
// a blank (with no text) option will be added
$builder->add('states', 'choice', array(
'required' => false,
));
));