Skip to content

Created information for framework session.name reference #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2013
Merged

Created information for framework session.name reference #2587

merged 1 commit into from
May 4, 2013

Conversation

stollr
Copy link

@stollr stollr commented May 3, 2013

Since the documentation has no information about framework.session.name. I want to add some.

@wouterj
Copy link
Member

wouterj commented May 3, 2013

👍

(could you please add the pull request format?)

weaverryan added a commit that referenced this pull request May 4, 2013
Created information for framework session.name reference
@weaverryan weaverryan merged commit d75d7f4 into symfony:2.0 May 4, 2013
@weaverryan
Copy link
Member

Hi Christian!

I love it! There are lots of reference options to define, so I love seeing new ones documented!

Thanks!

@stollr stollr deleted the session_name_reference branch May 6, 2013 06:11
@stollr
Copy link
Author

stollr commented May 6, 2013

@wouterj thanks for the hint. But one question about the "pull request format":

  • What means "Doc fix?". Is it only about fixing errors in the existing documentation or also about new documentation?

@wouterj
Copy link
Member

wouterj commented May 6, 2013

IMO, doc fix means modifing the current docs to be up to date with new features. New docs means a new section or paragraph that is added.

@stollr
Copy link
Author

stollr commented May 6, 2013

Okay, now it's clear ;-) thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants