Skip to content

Added missing UniqueEntity ignoreNull documentation #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2013

Conversation

jockri
Copy link
Contributor

@jockri jockri commented Apr 25, 2013

The ignoreNull options was added to the UniqueEntity constraint on 6 Aug 2012, but there was no documentation created for it. The PR with the code changes was merged after the release of SF 2.0

Q A
Doc fix? yes
New docs? yes (symfony/symfony#5015)
Applies to 2.1+
Fixed tickets N/A

Merge commit ref: symfony/symfony@0ccda38

**type**: ``Boolean`` **default**: ``true``

.. versionadded:: 2.1
The ``ignoreNull`` option was added in Symfony 2.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put this directive before the ignoreNull heading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wouterj Do you mean that I need to put the versionadded just before the ignoreNull heading? I just copied the options structure from http://symfony.com/doc/master/reference/constraints/UniqueEntity.html#repositorymethod on the same page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jockri yes, I prefer to have it on line 152 (in this case). I'll send a PR fixing it in the repositoryMethod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wouterj Done! I've also added a reference to the ignoreNull section in the options summary table.

@wouterj
Copy link
Member

wouterj commented Apr 25, 2013

👍 Thank you!

weaverryan added a commit that referenced this pull request May 4, 2013
Added missing UniqueEntity ignoreNull documentation
@weaverryan weaverryan merged commit 6982e9e into symfony:2.1 May 4, 2013
@weaverryan
Copy link
Member

Hey there!

Very nice work for an old feature that we missed on the docs :).

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants