Skip to content

Added tip regarding VoterInterface restrictions #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Added tip regarding VoterInterface restrictions #2532

wants to merge 3 commits into from

Conversation

peterrehm
Copy link
Contributor

Added tip about supportsAttribute and supportsClass
fixes #2493

Added tip about supportsAttribute and supportsClass
fixes #2493
@peterrehm
Copy link
Contributor Author

@weaverryan I thought about what we discussed and think a small hint is sufficient. The issue is not so big that it is worth to add an additional example.

@@ -100,6 +100,14 @@ and compare the IP address against a set of blacklisted IP addresses:
That's it! The voter is done. The next step is to inject the voter into
the security layer. This can be done easily through the service container.

.. tip::

The methods supportsAttribute() and supportsClass() are not being called
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please change this to an api link?

:method:`Symfony\\Component\\Security\\....::supportsAttribute`

@weaverryan
Copy link
Member

Hey Peter!

I agree - the note is a big improvement. I've patched it into the 2.0 branch at:

with minor tweaks at sha: 8cf1924

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of supportsAttribute and supportsClass in VoterInterface
3 participants