Updated contributor branch references - 2.0 no longer maintained #2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current documentation refers throughout to making bugfix and corrections against the 2.0 branch, however this is no longer maintained. Updated with references to 2.1 to make this more obvious to new contributors.
weaverryan
added a commit
that referenced
this pull request
May 3, 2013
Updated contributor branch references - 2.0 no longer maintained
|
Hi Andrew! Wow, this is perfect! This has been on my list to do for a few weeks, and you nailed it (even the PR image - extra credit for that!). At least for now, I think we should continue to make these changes going forward for each new, deprecated version. If/where it makes sense, we should remove specific versions (e.g. in one spot you removed "2.0" from a URL and replaced it with "current", which was a great idea). This will hopefully minimize the number of changes we need to make. And like I said, changing the image I think is extra credit - I would be ok if this didn't get updated very often :). I've made a note to use your PR as a reference going forward. Thanks! |
|
Hi @weaverryan thanks - glad you're happy with it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation refers throughout to making bugfix and corrections against the 2.0 branch, however this is no longer maintained. Updated with references to 2.1 to make this more obvious to new contributors.
Obviously this would then need to be repeated each time you drop support for an old version - I'm not sure if you want to go down that route. Alternatively perhaps it would be enough to leave the references in the examples but provide an obvious band on the code and documentation pages clearly showing the oldest maintained version number?