Added limitations in 'Managing Common Dependencies with Parent Services'... #2501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es' with a caution
|
Also, I have took ths commit (Fixing a bad merge conflict) and applied in my commit. |
|
you should not have taken this change in your own commit (your commit now duplicates the changeset in the history). You should have based yoru work on top of the existing branch. |
|
@stof, yeah thats true. I should not have taken this change but I would have had to work on bad merge conflict without fixing it. shall I make another pull request with keeping bad conflicts in code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a caution in 'Managing Common Dependencies with Parent Services' page.
Ref: Source code, Issue