Fix code file upload #2453
Closed
Fix code file upload #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
indeed my actuall implementation uses $this->file = null |
| @@ -408,7 +408,7 @@ Next, refactor the ``Document`` class to take advantage of these callbacks:: | |||
| // the entity from being persisted to the database on error | |||
| $this->getFile()->move($this->getUploadRootDir(), $this->path); | |||
|
|
|||
| $this->setFile(null); | |||
|
|
|||
There was a problem hiding this comment.
please remove the extra 2 lines
|
@weaverryan i also noticed that the third block in the page in the 2.2 branch and master branch is broken see the page http://symfony.com/doc/current/cookbook/doctrine/file_uploads.html |
|
ok, I'm doing a new PR |
Closed
weaverryan
added a commit
that referenced
this pull request
Jun 12, 2013
…(even though case does not matter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$this->setFile(null); is wrong because $this->temp was fill with $this->path
So the uploaded file was deleted just after uploaded