Skip to content

[WCM] [SecurityBundle] Document multiple IP matching in rules #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2013

Conversation

danfinnie
Copy link
Contributor

Q A
Doc fix? No
New docs? Yes, for pull request symfony/symfony#7251
Applies to 2.3 (I think, this pull request and the code pull request are against master)
Fixed tickets See above

This is the documentation for the pull request for multiple IP address matching in the request matcher against symfony.

I'm not sure exactly what Doc fix vs. new docs means but I basically just updated the example in the book to have 1 example with multiple IPs and added a .. versionadded notice. I wasn't sure if the changelog should be updated as well -- I couldn't tell if it was the changelog for the symfony code or for the documentation.

@wouterj
Copy link
Member

wouterj commented Apr 1, 2013

Officially, you should answer yes to New Docs? and add symfony/symfony#7251 in their. But you don't have to change it this time, I just say it if you are going to contribute more in the future.

@danfinnie
Copy link
Contributor Author

@wouterj I modified the original comment, might as well try to get it right the first time :). How's the updated version?

@wouterj
Copy link
Member

wouterj commented Apr 2, 2013

👍

weaverryan added a commit that referenced this pull request Apr 26, 2013
[WCM] [SecurityBundle] Document multiple IP matching in rules
@weaverryan weaverryan merged commit 5c262d0 into symfony:master Apr 26, 2013
@weaverryan
Copy link
Member

Hey Daniel!

Awesome PR and an easy merge for me!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants