Skip to content

setValues() instead of setValue() #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

setValues() instead of setValue() #2420

wants to merge 2 commits into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 30, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #2412

Sgoettschkes
Sgoettschkes reviewed Mar 30, 2013
View reviewed changes
components/dom_crawler.rst
@@ -278,16 +278,17 @@ To work with multi-dimensional fields::
<input name="multi[dimensional]" />
</form>

You must specify the fully qualified name of the field::
You must specify the values of multi-dimensional fields as arrays itself to
address which fields' values should be changed::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the old, short description better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it sounds better but it doesn't really match the code as you do not real fully qualified names. Any propositions for a better phrasing?

weaverryan added a commit that referenced this pull request Mar 31, 2013
@weaverryan
[#2420] Simplifying english
e5814e6
@weaverryan
Copy link
Member

Hey Christian!

I've patched this into the 2.0 branch at sha: f6d0476 and sha: e1be552. I also simplified the English in the description - I think the code below it is the most important: sha: e5814e6

Thanks!

@weaverryan weaverryan closed this Mar 31, 2013
@xabbuh xabbuh deleted the fix-set-values-instead-of-set-value branch May 2, 2013 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @weaverryan @Sgoettschkes