Skip to content

[WIP] Adding a testing/database cookbook #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2013
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cookbook/map.rst.inc
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@
* :doc:`/cookbook/testing/http_authentication`
* :doc:`/cookbook/testing/insulating_clients`
* :doc:`/cookbook/testing/profiling`
* :doc:`/cookbook/testing/database`
* :doc:`/cookbook/testing/doctrine`
* :doc:`/cookbook/testing/bootstrap`
* (email) :doc:`/cookbook/email/testing`
Expand Down
114 changes: 114 additions & 0 deletions cookbook/testing/database.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
.. index::
single: Tests; Database

How to test code which interacts with the database
==================================================

If your code interacts with the database, e.g. reads data from or stores data into
it, you need to adjust your tests to take this into account. There are many ways
how to deal with this. In a unit test, you can create a mock for a ``Repository``
and use it to return expected objects. In a functional test, you may need to
prepare a test database with predefined values, so a test always has the same data
to work with.

Mocking the ``Repository`` in a Unit Test
-----------------------------------------

If you want to test code which depends on a doctrine ``Repository`` in isolation, you
need to mock the ``Repository``. Normally you get the ``Repository`` from the ``EntityManager``,
so you would need to mock those as well. Suppose the class you want to test looks like this::

namespace Acme\DemoBundle\Salary;

use Doctrine\Common\Persistence\ObjectManager;

class SalaryCalculator
{
private $entityManager;

public function __construct(ObjectManager $entityManager)
{
$this->entityManager = $entityManager;
}

public function calculateTotalSalary($id)
{
$employeeRepository = $this->entityManager->getRepository('AcmeDemoBundle::Employee');
$employee = $userRepository->find($id);

return $employee->getSalary() + $employee->getBonus();
}
}

As the ``ObjectManager`` gets injected into the class through the constructor, it's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use some api link here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wouterj API links don't work for Doctrine interfaces

easy to pass a mock object within a test::

use Acme\DemoBundle\Salary\SalaryCalculator;

class SalaryCalculatorTest extends \PHPUnit_Framework_TestCase
{

public function testCalculateTotalSalary()
{
// First, mock the object to be used in the test
$employee = $this->getMock('\Acme\DemoBundle\Entity\Employee');
$employee->expects($this->once())
->method('getSalary')
->will($this->returnValue(1000));
$employee->expects($this->once())
->method('getBonus')
->will($this->returnValue(1100));

// Now, mock tthe repository so it returns the mock of the employee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: the

$employeeRepository = $this->getMockBuilder('\Doctrine\ORM\EntityRepository')
->disableOriginalConstructor()
->getMock();
$employeeRepository->expects($this->once())
->method('__call')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You test uses find, not a method going through the __call implementation

->will($this->returnValue($employee));

// Last, mock the EntityManager to return the mock of the repository
$entityManager = $this->getMockBuilder('\Doctrine\ORM\EntityManager')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As your typehint is the ObjectManager, I would mock the ObjectManager interface only

->disableOriginalConstructor()
->getMock();
$entityManager->expects($this->once())
->method('getRepository')
->will($this->returnValue($employeeRepository));

$salaryCalculator = new SalaryCalculator($entityManager);
$this->assertEquals(1100, $salaryCalculator->calculateTotalSalary(1));
}
}

We are building our mocks from the inside out, first creating the employee which
gets returned by the ``Repository`` which itself gets returned by the ``EntityManager``.
This way, no real class is involved in testing.

.. note::

As a ``Repository`` doesn't have a ``find()`` method but uses the magic method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong. find is not a magic method (it is even part of the common ObjectRepository interface)

``__call``, you cannot define a mock method on ``find()`` but must instead use
``__call``. It's possible to implement the ``find()`` method in your ``Repository``
and use it when mocking. In this case, make sure to mock your ``Repository``
class instead of the generic ``EntityRepository``.

Changing database settings for functional tests
-----------------------------------------------

If you have functional tests, you want them to interact with a real database.
Most of the time you want to use a dedicated database connection to make sure
not to overwrite data you entered when developing the application and also
to be able to clear the database before every test.

To do this, you can specify the database configuration inside your ``app/config/config_test.yml``::

doctrine:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:

[...] inside your ``app/config/config_test.yml``:

.. code-block:: yaml

    doctrine:
        # ...

dbal:
host: localhost
dbname: testdb
user: testdb
password: testdb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add other formats as well


Make sure that your database runs on localhost and has the defined database and
user credentials set up.

1 change: 1 addition & 0 deletions cookbook/testing/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ Testing
http_authentication
insulating_clients
profiling
database
doctrine
bootstrap