Skip to content

[RFC] advance sample on internals rewrite #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RFC] advance sample on internals rewrite #2405

wants to merge 1 commit into from

Conversation

cordoval
Copy link
Contributor

@wouterj
Copy link
Member

wouterj commented Mar 30, 2013

👍

@cordoval cordoval mentioned this pull request Mar 30, 2013
Closed
stof
stof reviewed Mar 30, 2013
View reviewed changes
components/http_kernel/introduction.rst
@@ -259,6 +259,8 @@ will be called after another event - ``kernel.controller`` - is dispatched.
There are also a few other variations on the above process (e.g. if
you're registering your controllers as services).

.. _component-http-kernel-controller-event:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be component-http-kernel-kernel-controller to be consistent

@cordoval
rewrite of internals
b1ea84f 
advance sample on internals rewrite
add links to components for foundation and kernel
link more events and add link of missing terminate event
keep </ consistency
fix as </ is for paths and not for references
changed reference link as per stof's comment
@cordoval
Copy link
Contributor Author

cordoval commented Apr 6, 2013

@wouterj @weaverryan ready afaik

@wouterj
Copy link
Member

wouterj commented Apr 6, 2013

👍

weaverryan added a commit that referenced this pull request Apr 26, 2013
@weaverryan
[#2405] Porting kernel.terminate changes into the 2.1 branch
38e76bb
@weaverryan
Copy link
Member

Hey Luis!

I've patched this into the 2.0 branch at sha: a54b298 and ported some additional things to the 2.1 branch at sha: 38e76bb

Thanks!

@weaverryan weaverryan closed this Apr 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cordoval @wouterj @weaverryan @stof