Skip to content

Cleaned up typos in chapter comparing Sf2 and sf1 #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2013

Conversation

caponica
Copy link
Contributor

Fixed name of Symfony Standard Edition and bundle/bundles typos.

Note: however in 2.1.x onwards vendor/bundles is not used any more (and default app/autoload.php doesn't look like this), so might be better to rewrite the autoloader section completely with an Acme example - or explain the new vendor autoloader.

Q A
Doc fix? yes
New docs? no
Applies to 2.0
Fixed tickets N/A

Fixed paths to example autoloader files (...bundles not ...bundle)
@wouterj
Copy link
Member

wouterj commented Mar 20, 2013

If I'm correct, this article is already rewritten for 2.1.x? ( #1996 )

@@ -20,7 +20,7 @@ So, sit back and relax as you travel from "then" to "now".
Directory Structure
-------------------

When looking at a Symfony2 project - for example, the `Symfony2 Standard`_ -
When looking at a Symfony2 project - for example, the `Symfony2 Standard Edition`_ -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also change this on the bottom of the page (where all links are placed)

@caponica
Copy link
Contributor Author

I'll update this to include the reference at the bottom of the page (I missed that one!), the change to the bundle/bundles typo was just because I was there.

I didn't realise this block had been updated since I was reading a PDF version of the 2.1 book generated in late 2012. I'll double-check the latest version before making any further pull requests or comments!

However, the later versions still talk about vendor/bundles, which I don't think is correct any more...

Quote from latest version:

As mentioned before, for the autoloader to work, it needs to know that the Sensio namespace
lives in the vendor/bundles directory and that...

However, as I'm quite new to Symfony namespaces and autoloading (and composer), I'm not clear enough about this to correct it.

@wouterj
Copy link
Member

wouterj commented Mar 21, 2013

However, as I'm quite new to Symfony namespaces and autoloading (and composer), I'm not clear enough about this to correct it.

Yes, this is correct. That should get changed against the 2.1 branch. Moreover, that sentence (and code block) is not relevant in 2.1, as Composer handles the autoloading of every package you get.

@caponica
Copy link
Contributor Author

Should I open a ticket to flag this bit for a rewrite? If I was more experienced I'd try it myself but I don't want to confuse people even more!

@wouterj
Copy link
Member

wouterj commented Mar 21, 2013

@caponica yes, you can create a issue for that. It's a great issue to fix on the hack day (as it is not that hard to fix).

weaverryan added a commit that referenced this pull request Mar 30, 2013
Cleaned up typos in chapter comparing Sf2 and sf1
@weaverryan weaverryan merged commit 31ac1a4 into symfony:2.0 Mar 30, 2013
@weaverryan
Copy link
Member

Hi Christian!

Very nice fixes here! I've merged this in.

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants