Creating parameters page in DI component #2322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <service id="mailer" class="Mailer"> | ||
| <argument>%mailer.transport%</argument> | ||
| </service> | ||
|
|
|
👍 I like it (expect from those minor fixes), making the book articles shorter is an important thing. |
|
Should all be sorted now - I should have had a better check of the bits I moved from elsewhere :) |
|
|
||
| .. code-block:: php | ||
|
|
||
| ->addArgument('http://symfony.com/?foo=%%s&bar=%%d'); |
There was a problem hiding this comment.
this configuration-block needs to be indented one level
weaverryan
added a commit
that referenced
this pull request
Mar 30, 2013
Creating parameters page in DI component
weaverryan
added a commit
that referenced
this pull request
Mar 30, 2013
…inks to areas where things were removed
|
Hi Richard! This is an excellent example of carefully, but successfully, moving things into the component documentation. It's very nice! I made a few small tweaks, but the notable one is that if when you removed a section, I put it back, but with just a link to the new spot for that documentation. I think this pretty effectively allows us to continue to make cookbooks readable (and not incomplete) without duplication. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved some of the parameters related content that was spread around the docs into a single page in the DI component section as well as adding a bit more to the page.