Add information about CIDR notation support in trusted proxy list #2287
Conversation
lazyhammer
commented
Mar 9, 2013
lazyhammer
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#7312) |
| Applies to | 2.3 |
| Fixed tickets | n/a |
| CIDR notation support was introduced, so you can whitelist whole | ||
| subnets (e.g. ``10.0.0.0/8``, ``fc00::/7``). | ||
|
|
||
| :: |
There was a problem hiding this comment.
You should use .. code-block:: php here
There was a problem hiding this comment.
But there is a rule in contributing guidelines that says you have to prefer :: over .. code-block:: php
There was a problem hiding this comment.
yes, but not in this case. The :: is used in sentences that ends with a colon, e.g: See this example:. In that case, instead of adding .. code-block:: php 2 lines after this sentences, you should use ::: See this example::. Sphinx will display the indented text under it as PHP code and change :: into :.
But, 👍 for reading the standards before contributing!!
There was a problem hiding this comment.
Fixed. Thanks for clarification!
This PR was merged into the master branch. Discussion ---------- [HttpFoundation][FrameworkBundle] Add CIDR notation support in trusted proxy list | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7312, #7262 | License | MIT | Doc PR | symfony/symfony-docs#2287 Should be rebased once #7734 is merged. Commits ------- 7b32794 [HttpFoundation] updated CHANGELOG e7c1696 [HttpFoundation] refactored code to avoid code duplication 1695067 [HttpFoundation] added some unit tests for ranges of trusted IP addresses 811434f Allow setting trusted_proxies using CIDR notation ddc9e38 Modify Request::getClientIp() to use IpUtils::checkIp()
|
Rebased. |
[WaitingCodeMerge] Add information about CIDR notation support in trusted proxy list
|
Well-done, perfect PR! Thanks Dmitrii! |
