Fixed the serializer initialization for 2.0 #2258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Feb 22, 2013
Fixed the serializer initialization for 2.0
weaverryan
added a commit
that referenced
this pull request
Feb 22, 2013
This reverts commit a38b44e. This change only applied to 2.0, the original docs were correct for 2.1+
|
Awesome, thanks @stof! I've reverted it exactly as you said. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 2.0 was using an associative array to associate encoders to formats. So the code was wrong.
This change should then be reverted when merging into the 2.1 branch as 2.1 does not bother about the key. The format support is handled by each encoder (which allows splitting the encoder and the decoder into 2 different classes for the same format for instance, or to use the same encoder for several formats)