Skip to content

[Cookbook][Bundles][Extension] Fix typos and improve readability #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2013
Merged

[Cookbook][Bundles][Extension] Fix typos and improve readability #2252

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad831bc
Fix naming of __construct()
johnkary Feb 19, 2013
6f71062
Improve readability
johnkary Feb 19, 2013
12b8be3
Remove extra whitespace
johnkary Feb 19, 2013
fd9a696
Add API doc links
johnkary Feb 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cookbook/bundles/extension.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ as integration of other related components:

framework:
# ...
form: true
form: true

.. code-block:: xml

Expand All @@ -33,7 +33,7 @@ as integration of other related components:

$container->loadFromExtension('framework', array(
// ...
'form' => true,
'form' => true,
// ...
));

Expand Down Expand Up @@ -494,9 +494,9 @@ be output to the console in yaml.

As long as your bundle's configuration is located in the standard location
(``YourBundle\DependencyInjection\Configuration``) and does not have a
``__constructor()`` it will work automatically. If you have a something
different your ``Extension`` class will have to override the
``Extension::getConfiguration()`` method. Have it return an instance of your
``__construct()`` it will work automatically. If you have something
different, your ``Extension`` class must override the
``Extension::getConfiguration()`` method and return an instance of your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an API doc link here:

:method:`Extension::getConfiguration() <Symfony\\Component\\HttpKernel\\DependencyInjection\\Extension::getConfiguration>`
method and return an instance of your

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it here, also for a second instance in the article for Symfony\Component\HttpKernel\Bundle\Bundle::build

``Configuration``.

Comments and examples can be added to your configuration nodes using the
Expand Down