Adding a tip on using doctrine as a service #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The #2224 issue should be added to the Q/A table (in the last row), as this PR fixes that issue. I think we should do this for the other book articles. For instances, a note about the |
|
I think it is worth doing for those articles as well. @weaverryan what do you think? |
weaverryan
added a commit
that referenced
this pull request
Feb 19, 2013
Adding a tip on using doctrine as a service
|
Hi guys! In general, the conversation in #2224 makes sense to me, and I'm a fan of mentioning which services we're working with somewhere near where we're working with them. Hopefully this will help a bit :). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in GH-2224.