Added trans_default_domain tag to twig reference and some formatting #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Mar 4, 2013
Added trans_default_domain tag to twig reference and some formatting
weaverryan
added a commit
that referenced
this pull request
Mar 4, 2013
…ets (since there is no header beneath the target)
|
Awesome WouterK (and another issue closed)! Sorry for the delay on this - I just needed to find the time to pull down and review the points you made above. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is splitted in 3 commits:
book/translationto match the common style, this is in for discussion