Skip to content

Update reference/configuration/framework.rst #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update reference/configuration/framework.rst #2198

wants to merge 2 commits into from

Conversation

loalf
Copy link

@loalf loalf commented Jan 31, 2013


This determines the path to set in the session cookie. By default it will use ``/``.

In Symfony 2.1 and before this option was formerly known as ``path``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put this just after the heading and in a .. versionadded:: 2.1 block. The same for all the other references like this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide an example where this .. versionadded:: 2.1 is being used ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loalf yes, of course. For instance, see the result here and the code here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

weaverryan added a commit that referenced this pull request Feb 3, 2013
@weaverryan
Copy link
Member

Awesome work Javier! I've patched this into the 2.1 branch at sha: cce310f and sha: cf74914 with some tweaks at sha: 153e180.

Thanks for this - I'm always very happy to have more of the configuration options documented well.

Cheers!

@weaverryan weaverryan closed this Feb 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants