Skip to content

tweaked the text to be clearer about how to use the checklist #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2013
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions contributing/code/patches.rst
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,10 @@ pull request message, like in:
[Yaml] fixed something
[Form] [Validator] [FrameworkBundle] added something

The pull request description must include the following check list to ensure
that contributions may be reviewed without needless feedback loops and that
your contributions can be included into Symfony2 as quickly as possible:
The pull request description must include the following check list at the top
of to ensure that contributions may be reviewed without needless feedback
loops and that your contributions can be included into Symfony2 as quickly as
possible:

.. code-block:: text

Expand Down Expand Up @@ -296,8 +297,9 @@ An example submission could now look as follows:
| License | MIT
| Doc PR | symfony/symfony-docs#123

For typos, minor changes in the PHPDocs, or changes in translation files, use
the shorter version of the check-list:
The whole table must be included (do **not** remove lines that you think are
not relevant). For simple typos, minor changes in the PHPDocs, or changes in
translation files, use the shorter version of the check-list:

.. code-block:: text

Expand Down