Skip to content

Use routes for security paths, instead of raw paths #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jan 16, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.1+
Fixed tickets #2108

There where 3 articles where the old raw paths where used: book/security, quick_tour/the_controller and reference/configuration/security I haven't changed the quick tour article, because the SE still uses raw paths in their default security configuration file. However, I have updated the book article and the reference.

login_path: /login
check_path: /login_check
login_path: login
check_path: login_check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the XML and PHP formats here as well

@wouterj
Copy link
Member Author

wouterj commented Feb 7, 2013

@weaverryan I have fixed the issues you mentioned. In cookbook/security/form_login, we use the failure_path and default_target_path. Shouldn't these be updated aswell?

weaverryan added a commit that referenced this pull request Feb 11, 2013
Use routes for security paths, instead of raw paths
@weaverryan weaverryan merged commit c9bd8f6 into symfony:2.1 Feb 11, 2013
@weaverryan
Copy link
Member

Thanks @wouterj! I've made one other small tweak, I think we've covered everything, but this chapters probably will need to be re-read for consistency sometime soon (ideally on the hack day).

@weaverryan
Copy link
Member

@wouterj I would assume that failure_path and default_target_path also accept routes, though I haven't personally tried this. We should test that out and then yes, change those as well. If you want to open a separate issue for those, that would be perfectly fine.

@stof
Copy link
Member

stof commented Feb 14, 2013

default_target_path accepts it. I switched it to a route in my project yesterday and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants