Skip to content

askAndConfirm should return user's input to properly work. #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2013

Conversation

gnikyt
Copy link

@gnikyt gnikyt commented Jan 15, 2013

The docs are missing the reutrn $answer in the askAndValidate example. Without it, askAndValidate will not return the user's input if the validation was successful.

in the console, so it is a good practice to put some useful information
in it.
in the console, so it is a good practice to put some useful information in it. The callback
function should also return the value of the user's input if the validatation was successfull.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here

@gnikyt
Copy link
Author

gnikyt commented Jan 15, 2013

@stof I have fixed the typos.

weaverryan added a commit that referenced this pull request Jan 20, 2013
askAndConfirm should return user's input to properly work.
@weaverryan weaverryan merged commit dbcd3cd into symfony:2.0 Jan 20, 2013
@weaverryan
Copy link
Member

Hi Tyler!

Excellent fix and perfect PR. Thanks for the contribution!

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants