Skip to content

Added missing path prefix /admin to access_control #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2013

Conversation

gido
Copy link
Contributor

@gido gido commented Jan 13, 2013

To be coherent with the great table and explanation written by @weaverryan in 682e86f

weaverryan added a commit that referenced this pull request Jan 14, 2013
Added missing path prefix `/admin` to access_control
@weaverryan weaverryan merged commit 7e0dfd8 into symfony:2.0 Jan 14, 2013
weaverryan added a commit that referenced this pull request Jan 14, 2013
…ess_control keys - unless suffixed with the regex $ - are not exact matches
@weaverryan
Copy link
Member

Hey Gilles!

Ah yes, thanks so much for fixing this - it's something I very much want to be perfect. I tweaked things again in sha: 98c7fcc - my original intention was to use an example that shows that the access_control entries are not exact matches (unless you terminate with $).

Thanks!

@gido
Copy link
Contributor Author

gido commented Jan 14, 2013

Hi Ryan,

Oh, I see. It's a good thing to insist on the fact that path is a pattern for a RegExp.

Thanks for your time to improve the documentation !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants