Skip to content

Add Service Configurator documentation. #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2013

Conversation

ronnylt
Copy link
Contributor

@ronnylt ronnylt commented Jan 6, 2013

This PR adds documentation for the Service Configurator feature of the Dependency Injection component.

For example, suppose you have an application where you send different types of
emails to users. Emails are passed through different formatters that could be
enabled or not depending on some dynamic application settings. You start
defining a Newsletter Manager class like this::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

defining a ``NewsletterManager`` class like this::

@ronnylt
Copy link
Contributor Author

ronnylt commented Jan 6, 2013

Fixed CS issues.



As commented before, the formatters should be set at runtime depending on
application settings, so we also have a ``FormatterManager`` class which is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a EmailFormatterManager

@ronnylt
Copy link
Contributor Author

ronnylt commented Jan 6, 2013

@stof Ok, fixed that sentence.

weaverryan added a commit that referenced this pull request Jan 27, 2013
Add Service Configurator documentation.
@weaverryan weaverryan merged commit 5c3f100 into symfony:2.0 Jan 27, 2013
weaverryan added a commit that referenced this pull request Jan 27, 2013
…so removing parameter use in examples for simplicity
@weaverryan
Copy link
Member

Awesome job Ronny! This is such a cool feature and you did a wonderful job covering it - thanks for the great contribution! I made minor tweaks to the document - if you see anything you don't like, please let me know!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants