Skip to content

Add hint to configure document root #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2013
Merged

Add hint to configure document root #2100

merged 2 commits into from
Jan 27, 2013

Conversation

bjo3rnf
Copy link
Contributor

@bjo3rnf bjo3rnf commented Jan 4, 2013

Urls shown in the installation chapter of the 2.1.* branch are missing the Symfony/web part. I added a hint about changing the document root and moved the links to apache and nginx docs.

@wouterj
Copy link
Member

wouterj commented Jan 4, 2013

This is somewhat equal to the note in quick_tour/the_big_picture. We could maybe at a link to these docs their too?

@@ -179,6 +177,16 @@ Symfony2 should welcome and congratulate you for your hard work so far!

.. image:: /images/quick_tour/welcome.jpg

.. note::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A .. tip:: block is maybe better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, agreed.

Am 04.01.2013 14:16, schrieb Wouter J:

In book/installation.rst:

@@ -179,6 +177,16 @@ Symfony2 should welcome and congratulate you for your hard work so far!

.. image:: /images/quick_tour/welcome.jpg

+.. note::

A |.. tip::| block is maybe better?


Reply to this email directly or view it on GitHub
https://github.com/symfony/symfony-docs/pull/2100/files#r2549430.

:::::::::::::::::::::::::::::::::::::::

Björn Fromme
Webdevelopment

dreipunktnull
Elfen und Fromme GbR

Am Langen Siepen 18
42857 Remscheid

Telefon: +49 (0) 2191 - 4 61 58 36
Telefax: +49 (0) 2191 - 4 61 58 37

E-Mail: fromme@dreipunktnull.com
Web: http://www.dreipunktnull.com

:::::::::::::::::::::::::::::::::::::::

@bjo3rnf
Copy link
Contributor Author

bjo3rnf commented Jan 4, 2013

That's right, didn't know this note and had to read it three times to
understand it. Couldn't be more awkwardly constructed ;-) So should this
note be linked from the instructions page or mine from the quick tour?

But: If you don't read the quick tour chances are you fail when you
follow the 2.1.x docs closely plus this is quite frequently asked on the
forum BTW so I think it's worth mentioning.

@bjo3rnf
Copy link
Contributor Author

bjo3rnf commented Jan 4, 2013

The quick tour note you mentioned is wrong IMHO. The (2.1.x) docs assume that you create a vhost or change the document root...

@weaverryan
Copy link
Member

Hi guys!

I've made a few small tweaks to this general problem, merged in this PR, and also opened #2188 so that we can re-read and address this issue more holistically.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants