[Component][Finder] Documented potential pitfalls when using iterator_to_array() with Finder #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,16 @@ the Finder instance. | |||
| :phpfunction:`iterator_to_array` method, or get the number of items with | |||
| :phpfunction:`iterator_count`. | |||
|
|
|||
| .. tip:: | |||
There was a problem hiding this comment.
I think it is better to use a .. caution:: block here
…_to_array() with Finder.
weaverryan
added a commit
that referenced
this pull request
Jan 27, 2013
weaverryan
added a commit
that referenced
this pull request
Jan 27, 2013
[Component][Finder] Documented potential pitfalls when using iterator_to_array() with Finder
|
Awesome note Jakub! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented it to avoid future issues similar to symfony/symfony#6460