Fixed typos (2.2) #2084
Merged
Fixed typos (2.2) #2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The old files should be merged up to the 2.0 branch, the new files only in 2.1 or master, great catches through! |
Well, I don't see any solution except 3 PRs (for 2.0, 2.1 and master), but it looks ugly. Do you have any ideas? |
|
@unkind you can leave it what it is right now, but the next time you should create 3 PRs. You should fix all general typos in 2.0, typos in new files for 2.1 in 2.1 and typos new in 2.2 in the master branch. If @weaverryan merges your PR, he will backport the 2.0 changes to the 2.0 branch. |
|
@unkind really nice catches, and you made merging this much much easier by backporting to the other branches - thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR affects some new files, so I can't base my changes on 2.0/2.1 branches.