Skip to content

[FrameworkBundle] Using existing services as lock/semaphore resources #20738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented Mar 8, 2025

Closes #20230

@HypeMC HypeMC force-pushed the use-service-as-lock-or-semaphore-resource branch 3 times, most recently from c659976 to 7f89c8b Compare March 8, 2025 22:23
@HypeMC HypeMC force-pushed the use-service-as-lock-or-semaphore-resource branch from 7f89c8b to 8b245b2 Compare March 8, 2025 22:32
@javiereguiluz javiereguiluz merged commit 0fe53cb into symfony:7.2 Mar 10, 2025
3 checks passed
@javiereguiluz
Copy link
Member

javiereguiluz commented Mar 10, 2025

You are on a roll @HypeMC. Thanks a lot for your contributions!

While merging, I added the versionadded directive (see 9f396ee), which must be included for the docs of any new feature. The pattern is:

.. versionadded:: X.Y

    The ...... option/feature/etc. was introduced in Symfony X.Y.

Thanks!

@HypeMC HypeMC deleted the use-service-as-lock-or-semaphore-resource branch March 10, 2025 09:27
@HypeMC
Copy link
Member Author

HypeMC commented Mar 10, 2025

@javiereguiluz Thank you, I forgot about that 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants