[Messenger][Process] add fromShellCommandLine() documentation
#20681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
fromShellCommandLine() documentation
OskarStark
reviewed
Mar 10, 2025
OskarStark
reviewed
Mar 10, 2025
messenger.rst
Outdated
Comment on lines
2268
to
2270
| A static factory :method:`Symfony\\Component\\Process\\Messenger\\RunProcessMessage::fromShellCommandline` is also | ||
| available if you want to use features of your shell such as redirections or pipes. For more information, see the | ||
| dedicated :ref:`Using Features From the OS Shell <process-using-features-from-the-os-shell>` documentation. :: |
There was a problem hiding this comment.
Suggested change
| A static factory :method:`Symfony\\Component\\Process\\Messenger\\RunProcessMessage::fromShellCommandline` is also | |
| available if you want to use features of your shell such as redirections or pipes. For more information, see the | |
| dedicated :ref:`Using Features From the OS Shell <process-using-features-from-the-os-shell>` documentation. :: | |
| A static factory :method:`Symfony\\Component\\Process\\Messenger\\RunProcessMessage::fromShellCommandline` is also | |
| available if you want to use features of your shell such as redirections or pipes:: |
OskarStark
reviewed
Mar 10, 2025
Staormin
force-pushed
the
add-runprocessmessage-fromshellcommandline
branch
from
7020d3e to
f5164f7
Compare
|
Thank for the review @OskarStark, what about the incorrect :method:Symfony\Component\Process\Messenger\RunProcessMessage::fromShellCommandline link that doesn't point to the actual code, anything I can change to make it work? |
Lets ignore it for now, maybe this will change once merged |
OskarStark
approved these changes
Mar 12, 2025
|
Merged! Kevin, thanks and congrats on your first Symfony Docs contribution 🎉 Thanks Oskar for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20655
The :method:
Symfony\\Component\\Process\\Messenger\\RunProcessMessage::fromShellCommandlinein my docs point to the 7.1 branch on my local build, any idea how to make it point to 7.3?