[Validator] use named-arguments to configure validation constraint options #20596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
changed the title
carsonbot
changed the title
carsonbot
changed the title
xabbuh
force-pushed
the
issue-20589
branch
9 times, most recently
from
1cbec65 to
83edb8d
Compare
xabbuh
changed the title
xabbuh
force-pushed
the
issue-20589
branch
2 times, most recently
from
de324eb to
1d95068
Compare
OskarStark
approved these changes
Jan 24, 2025
xabbuh
force-pushed
the
issue-20589
branch
2 times, most recently
from
35d8c97 to
3635154
Compare
xabbuh
changed the title
xabbuh
force-pushed
the
issue-20589
branch
3 times, most recently
from
11b2c36 to
4f80c5a
Compare
xabbuh
force-pushed
the
issue-20589
branch
6 times, most recently
from
98fa7f2 to
df560bd
Compare
xabbuh
changed the title
xabbuh
force-pushed
the
issue-20589
branch
2 times, most recently
from
02052a8 to
4520de9
Compare
|
the PR is now ready to be reviewed |
javiereguiluz
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Wow, thanks a lot Christian for this big effort!
I love this ... but recently I was asked to never use named arguments neither in Symfony Docs nor the Symfony Blog because they can change and BC policy doesn't cover that.
I guess it's OK in this case, but I wanted to point this out. Thanks!
|
@javiereguiluz We probably need to document somewhere that we guarantee BC for named arguments in attribute class (this does not only apply to validation constraint class but also to e.g. the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20589