Adding documentation for the CardScheme validation. #2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * LASER | ||
| * MAESTRO | ||
| * MASTERCARD | ||
| * VISA |
There was a problem hiding this comment.
Since you'll use these strings in your code, wrap each of them with the double-tick:
``AMEX``
|
Hi Sebastian! This is really wonderful, great work! I've just added a few small comments, and then I'll merge. I think the link to Wikipedia is a great idea - Symfony isn't "inventing" these schemes, we're just re-using public knowledge, and I think it's great to point that out. Thanks! |
|
Glad you like it. I did the changes you asked for. |
weaverryan
added a commit
that referenced
this pull request
Dec 30, 2012
Adding documentation for the CardScheme validation.
weaverryan
added a commit
that referenced
this pull request
Dec 30, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2023, I documented the CardScheme using the Luhn Validation as a template.
I also added a link to wikipedia, which I am not sure about. Please have a look and tell me what you think.