[Mercure] Actually using the env vars #20379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasLandauer
changed the title
Page: https://symfony.com/doc/5.x/mercure.html#configuration Reason: The above paragraph explains how to set all those vars in `.env`, but then the code sample didn't use it ;-)
javiereguiluz
force-pushed
the
patch-22
branch
from
3ce1235 to
8f1912f
Compare
|
Thanks Thomas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://symfony.com/doc/5.x/mercure.html#configuration
Reasons:
.env, but then the code sample didn't use it ;-)topic, so changing that accordingly.