Add BC promise rules for constructors #20307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Oct 8, 2024
wouterj
reviewed
Oct 8, 2024
stof
reviewed
Oct 8, 2024
| Remove argument No :ref:`[3] <note-3>` | ||
| Add default value to an argument Yes | ||
| Remove default value of an argument No | ||
| Add type hint to an argument No |
There was a problem hiding this comment.
we should probably update the whole table (maybe in a separate PR) to stop talking about type hint. Those are not hints at all. the right term for that is type, or maybe native type if we want to compare it to phpdoc-declared types.
There was a problem hiding this comment.
I agree, I'll have a loot at it once this one is merged
alexandre-daubois
force-pushed
the
constructor-bc
branch
from
5abdf34 to
72d416c
Compare
|
Merged! Thanks Alex. If further tweaks are needed, we can do that in future PRs. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in symfony/symfony#58490, following symfony/symfony#58490 (comment)